On 12/16/2023 5:05 AM, Konrad Dybcio wrote:
On 15.12.2023 11:18, Bibek Kumar Patro wrote:
Add ACTLR data table for SM8550 along with support for
same including SM8550 specific implementation operations.
Signed-off-by: Bibek Kumar Patro <quic_bibekkum@xxxxxxxxxxx>
---
[...]
+static const struct qcom_smmu_match_data sm8550_smmu_500_impl0_data = {
+ .impl = &qcom_smmu_500_impl,
+ .adreno_impl = &qcom_adreno_smmu_500_impl,
+ .cfg = &qcom_smmu_impl0_cfg,
+ .actlrcfg = sm8550_apps_actlr_cfg,
+ .actlrcfg_gfx = sm8550_gfx_actlr_cfg,
There are platforms that feature more than just APPS and Adreno SMMUs,
this implementation seems to assume there's only these two :/
Yes, some platforms can feature additional SMMUs as well including APPS
and Adreno. In that case there would be a corresponding compatible
string and an additional field in qcom_smmu_match_data might be needed.
Thanks,
Bibek
I suppose the only way to solve this would be to introduce new compatibles
for each one of them.. Krzysztof, do you think that's reasonable? E.g.
MSM8996 has at least 5 instances, 8998 has at least 4 etc.
Konrad
