On Fri, Dec 15, 2023 at 07:04:23PM -0500, Richard Acayan wrote: > On Fri, Dec 15, 2023 at 08:34:39AM +0100, Johan Hovold wrote: > > On Thu, Dec 14, 2023 at 08:46:27PM -0500, Richard Acayan wrote: > > > Tested-by: Richard Acayan <mailingradian@xxxxxxxxx> > > > > > > On a Pixel 3a, plugging in a USB cable doesn't wake up the device > > > (presumably because there is no wakeup-source property) but this gets > > > USB working again on linux-next. > > > > Thanks for testing. And yes, the wakeup interrupts will indeed not be > > enabled at system suspend unless the wakeup-source property is there. > > Did you try adding it? > > Just tested today. Adding it does not cause the system to wake up when > plugging in a laptop on the Pixel 3a, but that might just be because > USB wakeups are disabled when the adapter is configured for peripheral > mode. Right, wake up is currently only implemented for host mode. Johan