Re: [PATCH 1/3] soc: qcom: pmic_pdcharger_ulog: Search current directory for headers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/12/2023 00:05, Andrew Halaney wrote:
As specified in samples/trace_events/Makefile:

     If you include a trace header outside of include/trace/events
     then the file that does the #define CREATE_TRACE_POINTS must
     have that tracer file in its main search path. This is because
     define_trace.h will include it, and must be able to find it from
     the include/trace directory.

Without this the following compilation error is seen:

       CC      drivers/soc/qcom/pmic_pdcharger_ulog.o
     In file included from drivers/soc/qcom/pmic_pdcharger_ulog.h:36,
                      from drivers/soc/qcom/pmic_pdcharger_ulog.c:15:
     ./include/trace/define_trace.h:95:42: fatal error: ./pmic_pdcharger_ulog.h: No such file or directory
        95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
           |                                          ^
     compilation terminated.

Fixes: 086fdb48bc65 ("soc: qcom: add ADSP PDCharger ULOG driver")
Signed-off-by: Andrew Halaney <ahalaney@xxxxxxxxxx>
---
  drivers/soc/qcom/Makefile | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/soc/qcom/Makefile b/drivers/soc/qcom/Makefile
index 110108e23669..05b3d54e8dc9 100644
--- a/drivers/soc/qcom/Makefile
+++ b/drivers/soc/qcom/Makefile
@@ -10,6 +10,7 @@ obj-$(CONFIG_QCOM_PDR_HELPERS)	+= pdr_interface.o
  obj-$(CONFIG_QCOM_PMIC_GLINK)	+= pmic_glink.o
  obj-$(CONFIG_QCOM_PMIC_GLINK)	+= pmic_glink_altmode.o
  obj-$(CONFIG_QCOM_PMIC_PDCHARGER_ULOG)	+= pmic_pdcharger_ulog.o
+CFLAGS_pmic_pdcharger_ulog.o	:=  -I$(src)
  obj-$(CONFIG_QCOM_QMI_HELPERS)	+= qmi_helpers.o
  qmi_helpers-y	+= qmi_encdec.o qmi_interface.o
  obj-$(CONFIG_QCOM_RAMP_CTRL)	+= ramp_controller.o


I was able to reproduced it, and it only happens when we build in-tree, and checked
over the tree and indeed all the other trace drivers uses this flag to compile:

Reviewed-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>

Thanks for the fix!

Neil




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux