On Tue, 12 Dec 2023 at 02:23, Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> wrote: > > Add an API dpu_encoder_helper_phys_setup_cdm() which can be used by > the writeback encoder to setup the CDM block. > > Currently, this is defined and used within the writeback's physical > encoder layer however, the function can be modified to be used to setup > the CDM block even for non-writeback interfaces. > > Until those modifications are planned and made, keep it local to > writeback. > > changes in v3: > - call bind_pingpong_blk() directly as disable() is dropped > - add dpu_csc10_rgb2yuv_601l to dpu_hw_util.h and use it > - fix kbot error on the function doc > - document that dpu_encoder_helper_phys_setup_cdm() doesn't handle > DPU_CHROMA_H1V2 > > changes in v2: > - add the RGB2YUV CSC matrix to dpu util as needed by CDM > - use dpu_hw_get_csc_cfg() to get and program CSC > - drop usage of setup_csc_data() and setup_cdwn() cdm ops > as they both have been merged into enable() > - drop reduntant hw_cdm and hw_pp checks > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Closes: https://lore.kernel.org/oe-kbuild-all/202312102149.qmbCdsg2-lkp@xxxxxxxxx/ > Signed-off-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> > --- > .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 6 ++ > .../drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 93 ++++++++++++++++++- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.h | 14 +++ > 3 files changed, 112 insertions(+), 1 deletion(-) Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> -- With best wishes Dmitry
