On 12/10/23 19:17, Fenglin Wu via B4 Relay wrote: > From: Fenglin Wu <quic_fenglinw@xxxxxxxxxxx> > > Add RPMH regulators exposed by Qualcomm Technologies, Inc. PM8010 > PMIC. It has 7 LDOs with 3 different types, LDO1 - LDO2 are L502 > NMOS LDOs, LDO5 and LDO7 are L502 PMOS LDOs, LDO3/LDO4/LDO6 are > L502 PMOS LDO for low noise applications. Also, LDO3 - LDO7 don't > support LPM. > > Suggested-by: David Collins <quic_collinsd@xxxxxxxxxxx> > Signed-off-by: Fenglin Wu <quic_fenglinw@xxxxxxxxxxx> Reviewed-by: David Collins <quic_collinsd@xxxxxxxxxxx> > --- > drivers/regulator/qcom-rpmh-regulator.c | 62 +++++++++++++++++++++++++++++++++ > 1 file changed, 62 insertions(+) > > diff --git a/drivers/regulator/qcom-rpmh-regulator.c b/drivers/regulator/qcom-rpmh-regulator.c > index 43b45feb02e6..80e304711345 100644 > --- a/drivers/regulator/qcom-rpmh-regulator.c > +++ b/drivers/regulator/qcom-rpmh-regulator.c > @@ -511,6 +511,14 @@ static const int pmic_mode_map_pmic5_ldo[REGULATOR_MODE_STANDBY + 1] = { > [REGULATOR_MODE_FAST] = -EINVAL, > }; > > +static const int pmic_mode_map_pmic5_ldo_hpm[REGULATOR_MODE_STANDBY + 1] = { Minor: This is fine as-is. However, it might be a bit better with the name: "pmic_mode_map_pmic5_ldo_hpm_only". > + [REGULATOR_MODE_INVALID] = -EINVAL, > + [REGULATOR_MODE_STANDBY] = -EINVAL, > + [REGULATOR_MODE_IDLE] = -EINVAL, > + [REGULATOR_MODE_NORMAL] = PMIC5_LDO_MODE_HPM, > + [REGULATOR_MODE_FAST] = -EINVAL, > +}; > + > static unsigned int rpmh_regulator_pmic4_ldo_of_map_mode(unsigned int rpmh_mode) > { > unsigned int mode; > @@ -733,6 +741,33 @@ static const struct rpmh_vreg_hw_data pmic5_pldo515_mv = { > .of_map_mode = rpmh_regulator_pmic4_ldo_of_map_mode, > }; > > +static const struct rpmh_vreg_hw_data pmic5_pldo502 = { > + .regulator_type = VRM, > + .ops = &rpmh_regulator_vrm_ops, > + .voltage_ranges = (struct linear_range[]) { > + REGULATOR_LINEAR_RANGE(1504000, 0, 255, 8000), > + }, > + .n_linear_ranges = 1, > + .n_voltages = 256, > + .pmic_mode_map = pmic_mode_map_pmic5_ldo_hpm, > + .of_map_mode = rpmh_regulator_pmic4_ldo_of_map_mode, > +}; > + > +static const struct rpmh_vreg_hw_data pmic5_pldo502ln = { > + .regulator_type = VRM, > + .ops = &rpmh_regulator_vrm_ops, > + .voltage_ranges = (struct linear_range[]) { > + REGULATOR_LINEAR_RANGE(1800000, 0, 2, 200000), > + REGULATOR_LINEAR_RANGE(2608000, 3, 28, 16000), > + REGULATOR_LINEAR_RANGE(3104000, 29, 30, 96000), > + REGULATOR_LINEAR_RANGE(3312000, 31, 31, 0), > + }, > + .n_linear_ranges = 4, > + .n_voltages = 32, > + .pmic_mode_map = pmic_mode_map_pmic5_ldo_hpm, > + .of_map_mode = rpmh_regulator_pmic4_ldo_of_map_mode, > +}; > + > static const struct rpmh_vreg_hw_data pmic5_nldo = { > .regulator_type = VRM, > .ops = &rpmh_regulator_vrm_drms_ops, > @@ -759,6 +794,19 @@ static const struct rpmh_vreg_hw_data pmic5_nldo515 = { > .of_map_mode = rpmh_regulator_pmic4_ldo_of_map_mode, > }; > > +static const struct rpmh_vreg_hw_data pmic5_nldo502 = { > + .regulator_type = VRM, > + .ops = &rpmh_regulator_vrm_drms_ops, > + .voltage_ranges = (struct linear_range[]) { > + REGULATOR_LINEAR_RANGE(528000, 0, 127, 8000), > + }, > + .n_linear_ranges = 1, > + .n_voltages = 128, > + .hpm_min_load_uA = 30000, > + .pmic_mode_map = pmic_mode_map_pmic5_ldo, > + .of_map_mode = rpmh_regulator_pmic4_ldo_of_map_mode, > +}; > + > static const struct rpmh_vreg_hw_data pmic5_hfsmps510 = { > .regulator_type = VRM, > .ops = &rpmh_regulator_vrm_ops, > @@ -1210,6 +1258,16 @@ static const struct rpmh_vreg_init_data pm8009_1_vreg_data[] = { > {} > }; > > +static const struct rpmh_vreg_init_data pm8010_vreg_data[] = { > + RPMH_VREG("ldo1", "ldo%s1", &pmic5_nldo502, "vdd-l1-l2"), > + RPMH_VREG("ldo2", "ldo%s2", &pmic5_nldo502, "vdd-l1-l2"), > + RPMH_VREG("ldo3", "ldo%s3", &pmic5_pldo502ln, "vdd-l3-l4"), > + RPMH_VREG("ldo4", "ldo%s4", &pmic5_pldo502ln, "vdd-l3-l4"), > + RPMH_VREG("ldo5", "ldo%s5", &pmic5_pldo502, "vdd-l5"), > + RPMH_VREG("ldo6", "ldo%s6", &pmic5_pldo502ln, "vdd-l6"), > + RPMH_VREG("ldo7", "ldo%s7", &pmic5_pldo502, "vdd-l7"), > +}; > + > static const struct rpmh_vreg_init_data pm6150_vreg_data[] = { > RPMH_VREG("smps1", "smp%s1", &pmic5_ftsmps510, "vdd-s1"), > RPMH_VREG("smps2", "smp%s2", &pmic5_ftsmps510, "vdd-s2"), > @@ -1525,6 +1583,10 @@ static const struct of_device_id __maybe_unused rpmh_regulator_match_table[] = { > .compatible = "qcom,pm8009-1-rpmh-regulators", > .data = pm8009_1_vreg_data, > }, > + { > + .compatible = "qcom,pm8010-rpmh-regulators", > + .data = pm8010_vreg_data, > + }, > { > .compatible = "qcom,pm8150-rpmh-regulators", > .data = pm8150_vreg_data, >