On 09/12/2023 18:38, Konrad Dybcio wrote: > On 8.12.2023 11:51, Krzysztof Kozlowski wrote: >> PCI node in Qualcomm SC8180x DTS has 8 clocks: >> >> sc8180x-primus.dtb: pci@1c00000: 'oneOf' conditional failed, one must be fixed: >> ['pipe', 'aux', 'cfg', 'bus_master', 'bus_slave', 'slave_q2a', 'ref', 'tbu'] is too short >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> >> --- > [...] > >> + items: >> + - const: pipe # PIPE clock >> + - const: aux # Auxiliary clock >> + - const: cfg # Configuration clock >> + - const: bus_master # Master AXI clock >> + - const: bus_slave # Slave AXI clock >> + - const: slave_q2a # Slave Q2A clock >> + - const: ref # REFERENCE clock >> + - const: tbu # PCIe TBU clock > Are we sure this one is actually necessary? Or is it just for the > SMMU debug peripheral? [1] Would be nice to test if it works > normally (unused clk shutdown / forced shutdown of this one might > be necessary in case it's on from XBL) and during a PCIe-related > SMMU fault. I did not validate whether the list is actually correct with datasheets, but aligned it to DTS. I don't have the hardware to test. Best regards, Krzysztof
