On Thu, Dec 07, 2023 at 08:54:32PM +0200, Dmitry Baryshkov wrote: > On Thu, 7 Dec 2023 at 18:27, Bjorn Andersson <andersson@xxxxxxxxxx> wrote: > > > > On Wed, Nov 15, 2023 at 09:53:18PM +0100, Petr Vorel wrote: > > > From: Petr Vorel <petr.vorel@xxxxxxxxx> > > > > > > Enable support for the multimedia clock controller on SDM660 devices > > > and graphics clock controller on SDM630/636/660 devices. > > > > > > Signed-off-by: Petr Vorel <petr.vorel@xxxxxxxxx> > > > --- > > > Changes v1->v2: > > > * added commit message (not just the subject) > > > > > > NOTE motivation for this is that some not yet mainlined DTS already use > > > both: > > > > > > https://github.com/sdm660-mainline/linux/blob/sdm660-next-stable/arch/arm64/boot/dts/qcom/sdm636-asus-x00td.dts > > > > > > Kind regards, > > > Petr > > > > > > arch/arm64/configs/defconfig | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > > > index acba803835b9..10a098aa8b1b 100644 > > > --- a/arch/arm64/configs/defconfig > > > +++ b/arch/arm64/configs/defconfig > > > @@ -1235,6 +1235,8 @@ CONFIG_SC_GCC_8180X=y > > > CONFIG_SC_GCC_8280XP=y > > > CONFIG_SC_GPUCC_8280XP=m > > > CONFIG_SC_LPASSCC_8280XP=m > > > +CONFIG_SDM_MMCC_660=m > > > +CONFIG_SDM_GPUCC_660=y > > > > I'd expect the GPU clock controller to be a module, can you please > > clarify why it needs to be builtin? > > To allow the display to be enabled early enough? > If that's your goal, then it might be less optimal to have MMCC as a module... We should keep drivers essential for reaching the ramdisk as builtin (which pretty much means the stuff necessary to establish /dev/console), and then the rest as modules. There are several here which are =y because it used to be that probe deferral on power-domains didn't work. We should drop those to =m as well... Thanks, Bjorn > > > > Regards, > > Bjorn > > > > > CONFIG_SDM_CAMCC_845=m > > > CONFIG_SDM_GPUCC_845=y > > > CONFIG_SDM_VIDEOCC_845=y > > > -- > > > 2.42.0 > > > > > > > > -- > With best wishes > Dmitry
