On Fri, Dec 08, 2023 at 12:28:45PM +0530, Manivannan Sadhasivam wrote:
> Hello,
>
> This series has code some cleanups to the Qcom UFS driver. No functional
> change. In this version, I've removed code supporting legacy controllers
> ver < 2.0, as the respective platforms were never supported in upstream.
>
> Tested on: RB5 development board based on Qcom SM8250 SoC.
>
> - Mani
>
> Changes in v2:
>
> * Collected review tags
> * Fixed the comments from Andrew
> * Added a few more patches, most notably one removing the code for old
> controllers (ver < v2.0)
>
I took this for a spin on sa8775p-ride when developing another patch
today with no issues. Certainly doesn't hit all the cases here, but:
Tested-by: Andrew Halaney <ahalaney@xxxxxxxxxx> # sa8775p-ride
> Manivannan Sadhasivam (17):
> scsi: ufs: qcom: Use clk_bulk APIs for managing lane clocks
> scsi: ufs: qcom: Fix the return value of ufs_qcom_ice_program_key()
> scsi: ufs: qcom: Fix the return value when
> platform_get_resource_byname() fails
> scsi: ufs: qcom: Remove superfluous variable assignments
> scsi: ufs: qcom: Remove the warning message when core_reset is not
> available
> scsi: ufs: qcom: Export ufshcd_{enable/disable}_irq helpers and make
> use of them
> scsi: ufs: qcom: Fail ufs_qcom_power_up_sequence() when core_reset
> fails
> scsi: ufs: qcom: Check the return value of
> ufs_qcom_power_up_sequence()
> scsi: ufs: qcom: Remove redundant error print for devm_kzalloc()
> failure
> scsi: ufs: qcom: Use dev_err_probe() to simplify error handling of
> devm_gpiod_get_optional()
> scsi: ufs: qcom: Remove unused ufs_qcom_hosts struct array
> scsi: ufs: qcom: Sort includes alphabetically
> scsi: ufs: qcom: Initialize cycles_in_1us variable in
> ufs_qcom_set_core_clk_ctrl()
> scsi: ufs: qcom: Simplify ufs_qcom_{assert/deassert}_reset
> scsi: ufs: qcom: Remove support for host controllers older than v2.0
> scsi: ufs: qcom: Use ufshcd_rmwl() where applicable
> scsi: ufs: qcom: Remove unused definitions
>
> drivers/ufs/core/ufshcd.c | 6 +-
> drivers/ufs/host/ufs-qcom.c | 377 +++++-------------------------------
> drivers/ufs/host/ufs-qcom.h | 52 +----
> include/ufs/ufshcd.h | 2 +
> 4 files changed, 66 insertions(+), 371 deletions(-)
>
> --
> 2.25.1
>
