On Wed, Oct 25, 2023 at 02:49:28PM +0300, Dmitry Baryshkov wrote: > The UCSI firmware on Qualcomm SC8180X, SC8280XP and SM8350 are buggy. > Submitting UCSI_GET_PDOS command for partners which do not actually > support PD and do not have PDOs causes firmware to crash, preventing > further UCSI activity. Firmware on newer platforms have fixed this > issue. In order to still be able to use UCSI functionality on the > mentioned platforms (e.g. to be able to handle USB role switching), > apply a workaround that completely shortcuts UCSI_GET_PDOS command for > the USB-C partner. > > This has been tested on sm8350 only, but should apply to other > platforms. I did not enable UCSI for sc8180x yet, it has slightly > different implementation, which I'd like to get tested first. Has no one tested this on sc8280xp/x13s before merging? I see a bunch of errors with this series applied to 6.7-rc4: [ 11.999960] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: timeout waiting for UCSI sync write response [ 12.000430] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: ucsi_handle_connector_change: GET_CONNECTOR_STATUS failed (-110) [ 17.120515] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: timeout waiting for UCSI sync write response [ 17.124204] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: GET_CONNECTOR_STATUS failed (-110) [ 23.264792] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: timeout waiting for UCSI sync write response [ 23.264953] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: GET_CONNECTOR_STATUS failed (-110) Is it just broken or am I missing some undocumented dependency that is only in linux-next? Johan
