Re: [PATCH v3 2/3] dt-bindings: phy: qcom-edp: Add X1E80100 PHY compatibles

[Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>]

On 12/7/23 17:51, Krzysztof Kozlowski wrote:

[...]

> > +allOf:
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - qcom,x1e80100-dp-phy
> > +    then:
> > +      properties:
> > +        phy-type:
> > +          description: DP (default) or eDP type
>
> Properties must be defined in top-level "properties:" block. In
> allOf:if:then you only disallow them for other variants.
>
> > +          enum: [ 6, 13 ]
> > +          default: 6
>
> Anyway, I was thinking this should be rather argument to phy-cells.
I'm not sure I'm for this, because the results would be:

--- device.dts ---
&dp_controller0 {
    phys = <&dp_phy0 PHY_EDP>;
};

&dp_controller1 {
    phys = <&dp_phy1 PHY_DP>;
};
------------------

as opposed to:

--- device.dts ---
&dp_phy0 {
    phy-type <PHY_EDP>;
};

&dp_phy1 {
    phy-type = <PHY_DP>;
};
------------------

i.e., we would be saying "this board is connected to this phy
instead" vs "this phy is of this type on this board".

While none of them really fit the "same hw, different config"
situation, I'd vote for the latter one being closer to the
truth

Konrad