On Fri, Dec 01, 2023 at 08:44:09PM +0530, Manivannan Sadhasivam wrote:
> core_reset is optional, so there is no need to warn the user if it is not
> available (that too not while doing host reset each time).
What's the bit in the parenthesis mean here? I'm having a hard time
following. Otherwise, this looks good to me.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> ---
> drivers/ufs/host/ufs-qcom.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index dc93b1c5ca74..d474de0739e4 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -296,10 +296,8 @@ static int ufs_qcom_host_reset(struct ufs_hba *hba)
> struct ufs_qcom_host *host = ufshcd_get_variant(hba);
> bool reenable_intr;
>
> - if (!host->core_reset) {
> - dev_warn(hba->dev, "%s: reset control not set\n", __func__);
> + if (!host->core_reset)
> return 0;
> - }
>
> reenable_intr = hba->is_irq_enabled;
> disable_irq(hba->irq);
> --
> 2.25.1
>
>
