On 12/6/2023 7:25 PM, Krzysztof Kozlowski wrote:
On 05/12/2023 09:29, Mao Jinlong wrote:
Remote ETM(Embedded Trace Macrocell) is to capture information of
the executed processor instructions of remote processors like modem.
Add new coresight-remote-etm.yaml file describing the bindings
required to define coresight remote etm in the device trees.
Signed-off-by: Mao Jinlong <quic_jinlmao@xxxxxxxxxxx>
+description:
+ Support for ETM trace collection on remote processor using coresight
+ framework. Enabling this will allow turning on ETM tracing on remote
+ processor like modem processor via sysfs and collecting the trace
+ via coresight TMC sinks.
+
+properties:
+ compatible:
+ const: qcom,coresight-remote-etm
+
+ qcom,inst-id:
I did not receive my answer about this property one month ago, so:
NAK, drop this property.
Thanks for the review. I will remove this first and add it back with
driver codes.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description:
+ Each kind of remote ETM has its unique instance id. The remote etm will
+ be enabled/disabled on remote processor based on the id send from
+ ap processor.
+
+ out-ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+ additionalProperties: false
+
+ properties:
+ port:
+ description: Output connection to the CoreSight Trace bus.
+ $ref: /schemas/graph.yaml#/properties/port
+
+required:
+ - compatible
+ - qcom,inst-id
+ - out-ports
+
+additionalProperties: false
+
+examples:
+ - |
+ modem-etm0 {
etm {
+ compatible = "qcom,coresight-remote-etm";
+ qcom,inst-id = <2>;
+
+ out-ports {
+ port {
+ modem_etm0_out_funnel_modem: endpoint {
+ remote-endpoint = <&funnel_modem_in_modem_etm0>;
Missing indentation level
I will make changes in next version.
+ };
+ };
+ };
+ };
+...
Best regards,
Krzysztof
