Re: [PATCH v5 1/4] dt-bindings: pinctrl: qcom: Add SM4450 pinctrl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


在 11/30/2023 7:56 PM, Krzysztof Kozlowski 写道:
On 30/11/2023 03:40, Tengfei Fan wrote:
Add device tree binding Documentation details for Qualcomm SM4450
TLMM device.

Please use scripts/ to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time, thus I will skip this patch entirely till you follow
the process allowing the patch to be tested.

Please kindly resend and include all necessary To/Cc entries.
Sure, I will ensure that next version patch series base on the latest code, and use scripts/ to get a list of all necessary people and lists.

  .../bindings/pinctrl/qcom,sm4450-tlmm.yaml    | 151 ++++++++++++++++++
  1 file changed, 151 insertions(+)
  create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml


+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    tlmm: pinctrl@f100000 {
+      compatible = "qcom,sm4450-tlmm";
+      reg = <0x0f100000 0x300000>;
+      gpio-controller;
+      #gpio-cells = <2>;
+      gpio-ranges = <&tlmm 0 0 137>;
+      interrupt-controller;
+      #interrupt-cells = <2>;
+      interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
+      gpio-wo-state {
+          pins = "gpio1";

Messed indentation.
I will update this indent issue in next version patch series.

Best regards,

Thx and BRs,
Tengfei Fan

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux