Re: [PATCH] arm64: dts: qcom: msm8916/39-samsung-a2015: Add PMIC and charger

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/12/2023 10:38, Raymond Hackley wrote:
The phones listed below have Richtek RT5033 PMIC and charger.
Add them to the device trees.

- Samsung Galaxy A3/A5/A7 2015
- Samsung Galaxy E5/E7
- Samsung Galaxy Grand Max

Signed-off-by: Raymond Hackley <raymondhackley@xxxxxxxxxxxxxx>
---
  .../qcom/msm8916-samsung-a2015-common.dtsi    | 59 +++++++++++++++++-
  .../boot/dts/qcom/msm8916-samsung-a3u-eur.dts |  6 ++
  .../boot/dts/qcom/msm8916-samsung-a5u-eur.dts |  6 ++
  .../qcom/msm8916-samsung-e2015-common.dtsi    |  6 ++
  .../boot/dts/qcom/msm8916-samsung-e5.dts      |  6 ++
  .../boot/dts/qcom/msm8916-samsung-e7.dts      |  7 +++
  .../dts/qcom/msm8916-samsung-grandmax.dts     |  6 ++
  .../boot/dts/qcom/msm8939-samsung-a7.dts      | 62 ++++++++++++++++++-
  8 files changed, 156 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi b/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi
index 2937495940ea..e6355e5e2177 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi
@@ -28,6 +28,12 @@ tz-apps@85500000 {
  		};
  	};
+ battery: battery {
+		compatible = "simple-battery";
+		precharge-current-microamp = <450000>;
+		precharge-upper-limit-microvolt = <3500000>;
+	};
+
  	clk_pwm: pwm {
  		compatible = "clk-pwm";
  		#pwm-cells = <2>;
@@ -128,6 +134,12 @@ muic: extcon@25 {
pinctrl-names = "default";
  			pinctrl-0 = <&muic_int_default>;
+
+			usb_con: connector {
+				compatible = "usb-b-connector";
+				label = "micro-USB";
+				type = "micro";
+			};

It would be nice to break this up into individual patches

One patch for the battery, one patch for the usb-b-connector per device you are targetting.

More work but better practice to have more granular commits.


+		regulators {
+			rt5033_reg_safe_ldo: SAFE_LDO {
+				regulator-min-microvolt = <4900000>;
+				regulator-max-microvolt = <4900000>;
+				regulator-always-on;
+			};
+
+			/*
+			 * Needed for camera, but not used yet.
+			 * Define empty nodes to allow disabling the unused
+			 * regulators.
+			 */
+			LDO {};
+			BUCK {};
+		};

Aren't the camera regulators off until enabled ?

---
bod





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux