On Mon, 4 Dec 2023 at 20:07, Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> wrote: > On 10/3/2023 8:19 PM, Dmitry Baryshkov wrote: > > There are no in-kernel users of MSM_ENC_VBLANK wait type. Drop it > > together with the corresponding wait_for_vblank callback. > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > --- > > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 3 -- > > .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 1 - > > .../drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 28 ------------------- > > .../drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 9 +++--- > > drivers/gpu/drm/msm/msm_drv.h | 2 -- > > 5 files changed, 4 insertions(+), 39 deletions(-) > > > > No users today but will need to be added back when features such as > autorefresh get added. But, as usual, we go by what in the driver today > so I am aware that this will be a lost argument. Hmm, what is the difference between autorefresh and the PSR / self-refresh? > > Hence, > > > Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> -- With best wishes Dmitry