Re: [PATCH V2 1/3] ufs: core: Add CPU latency QoS support for ufs driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 12/4/23 06:30, Maramaina Naresh wrote:
+	u32	(*config_qos_vote)(struct ufs_hba *hba);

Please remove the above callback since this patch series does not
introduce any instances of this callback.

+	/* This capability allows the host controller driver to use the PM QoS
+	 * feature.
+	 */
+	UFSHCD_CAP_PM_QOS				= 1 << 13,

Why does it depend on the host driver whether or not PM QoS is
enabled? Why isn't it enabled unconditionally?

+ * @pm_qos_req: PM QoS request handle
+ * @pm_qos_init: flag to check if pm qos init completed

Documentation for pm_qos_init is missing.

  struct ufs_hba {
  	void __iomem *mmio_base;
@@ -1076,6 +1089,9 @@ struct ufs_hba {
  	struct ufs_hw_queue *uhq;
  	struct ufs_hw_queue *dev_cmd_queue;
  	struct ufshcd_mcq_opr_info_t mcq_opr[OPR_MAX];
+	struct pm_qos_request pm_qos_req;
+	bool pm_qos_init;
+	u32 qos_vote;

Please rename "pm_qos_init" into "pm_qos_initialized".



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux