Re: [PATCH v5 2/4] pinctrl: qcom: Add SM4450 pinctrl driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


在 12/4/2023 3:56 PM, Krzysztof Kozlowski 写道:
On 04/12/2023 02:57, Tengfei Fan wrote:

在 11/30/2023 7:57 PM, Krzysztof Kozlowski 写道:
On 30/11/2023 03:40, Tengfei Fan wrote:
Add pinctrl driver for TLMM block found in SM4450 SoC.

Reviewed-by: Bjorn Andersson <andersson@xxxxxxxxxx>
Signed-off-by: Tengfei Fan <quic_tengfan@xxxxxxxxxxx>
   drivers/pinctrl/qcom/Kconfig.msm      |    8 +
   drivers/pinctrl/qcom/Makefile         |    1 +
   drivers/pinctrl/qcom/pinctrl-sm4450.c | 1013 +++++++++++++++++++++++++
   3 files changed, 1022 insertions(+)
   create mode 100644 drivers/pinctrl/qcom/pinctrl-sm4450.c

Hm, was this patch ever built?

Best regards,

This patch has been built before, I will check and compare if there are
any errors and changes when I submitted this patch series.

No, it wasn't built. I just tried - applied it and:

pinctrl-sm4450.c:996:19: error: initialization of ‘int (*)(struct
platform_device *)’ from incompatible pointer type ‘void (*)(struct
platform_device *)’ [-Werror=incompatible-pointer-types]
   996 |         .remove = msm_pinctrl_remove,
       |                   ^~~~~~~~~~~~~~~~~~
../drivers/pinctrl/qcom/pinctrl-sm4450.c:996:19: note: (near
initialization for ‘sm4450_tlmm_driver.remove’)

So you just sent a patch which was not even compiled.


Best regards,

I compiled all the related patches together, but I did not compile this patch separately. The fact that there is a compilation problem is known, but because the patch is already reviewed-by, so a separate patch(patch 3) is submitted to fix the compilation error.

The next version patch series will incorpotate the fix patch into this pinctrl driver patch as well.

Thx and BRs,
Tengfei Fan

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux