On Fri, 1 Dec 2023 10:01:33 -0700 Jeffrey Hugo <quic_jhugo@xxxxxxxxxxx> wrote: > > +DECLARE_EVENT_CLASS(mhi_process_event_ring, > > + > > + TP_PROTO(const char *name, void *rp, __le64 ptr, > > + __le32 dword0, __le32 dword1), > > + > > + TP_ARGS(name, rp, ptr, dword0, dword1), > > + > > + TP_STRUCT__entry( > > + __string(name, name) > > + __field(__le32, dword0) > > + __field(__le32, dword1) > > + __field(int, state) > > + __field(__le64, ptr) > > + __field(void *, rp) > > + ), > > + > > + TP_fast_assign( > > + __assign_str(name, name); > > + __entry->rp = rp; > > + __entry->ptr = ptr; > > + __entry->dword0 = dword0; > > + __entry->dword1 = dword1; > > + __entry->state = MHI_TRE_GET_EV_STATE((struct mhi_ring_element *)entry->rp); > > "entry"? > Also, you have the "rp" that was passed into the trace, why not just > directly use that? Agreed. -- Steve
