On Fri, Dec 01, 2023 at 08:43:20AM -0600, Rob Herring wrote: > On Thu, Nov 30, 2023 at 06:28:34PM +0100, Johan Hovold wrote: > > The Multi-Purpose Pin controller block is part of an SPMI PMIC (which in > > turns sits on an SPMI bus) and uses a single value for the register > > property that corresponds to its base address. > > > > Clean up the example by adding a parent PMIC node with proper > > '#address-cells' and '#size-cells' properties, dropping the incorrect > > second register value, adding some newline separators and increasing the > > indentation to four spaces. > > This is fine, but I prefer these MFDs have 1 complete example rather > than piecemeal examples for each child device. Yeah, this is not ideal. The closest thing we've got are the examples in: Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml Are you suggesting eventually dropping the examples from the child node bindings and adding (several) complete examples in the parent one? I guess there would need to be more than one if you want to cover all the various child nodes with real examples. Johan
