Lina Iyer <lina.iyer@xxxxxxxxxx> writes: > A PM domain comprising of CPUs may be powered off when all the CPUs in > the domain are powered down. Powering down a CPU domain is generally a > expensive operation and therefore the power performance trade offs > should be considered. The time between the last CPU powering down and > the first CPU powering up in a domain, is the time available for the > domain to sleep. Ideally, the sleep time of the domain should fulfill > the residency requirement of the domains' idle state. > > To do this effectively, read the time before the wakeup of the cluster's > CPUs and ensure that the domain's idle state sleep time guarantees the > QoS requirements of each of the CPU, the PM QoS CPU_DMA_LATENCY and the > state's residency. > > Signed-off-by: Lina Iyer <lina.iyer@xxxxxxxxxx> [...] > +static bool cpu_stop_ok(struct device *dev) > +{ > + return true; > +} > + > +struct dev_power_governor cpu_pd_gov = { > + .power_down_ok = cpu_pd_down_ok, > + .stop_ok = cpu_stop_ok, > +}; If stop_ok is unconditionally true, it should probably just be removed (IOW cpu_pd_gov->stop_ok == NULL), and that will avoid an unnecessary function call. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html