On Sat, Nov 11, 2023 at 08:02:59AM +0530, Mrinmay Sarkar wrote: > Without the prefix, the function name would appear as > "/sys/kernel/config/functions/{sdx55/sm8450}". This will be a problem if > multiple functions are supported for this endpoint device. > > So let's add the "pci_epf_mhi_" prefix to identify _this_ function > uniquely. Even though it is an ABI breakage, this driver is not used > anywhere outside Qcom and myself to my knowledge. So it safe to change > the function name. > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> Since I authored this patch and shared it with you, the authorship needs to be preserved. If you just apply the patch using 'git am' it would do the right thing. - Mani > Signed-off-by: Mrinmay Sarkar <quic_msarkar@xxxxxxxxxxx> > --- > drivers/pci/endpoint/functions/pci-epf-mhi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/endpoint/functions/pci-epf-mhi.c b/drivers/pci/endpoint/functions/pci-epf-mhi.c > index b7b9d3e..5b0515a 100644 > --- a/drivers/pci/endpoint/functions/pci-epf-mhi.c > +++ b/drivers/pci/endpoint/functions/pci-epf-mhi.c > @@ -677,8 +677,8 @@ static int pci_epf_mhi_probe(struct pci_epf *epf, > } > > static const struct pci_epf_device_id pci_epf_mhi_ids[] = { > - { .name = "sdx55", .driver_data = (kernel_ulong_t)&sdx55_info }, > - { .name = "sm8450", .driver_data = (kernel_ulong_t)&sm8450_info }, > + { .name = "pci_epf_mhi_sdx55", .driver_data = (kernel_ulong_t)&sdx55_info }, > + { .name = "pci_epf_mhi_sm8450", .driver_data = (kernel_ulong_t)&sm8450_info }, > {}, > }; > > -- > 2.7.4 > -- மணிவண்ணன் சதாசிவம்