> if (phydev->drv->phy_id == ATH8031_PHY_ID) { > + /* Disable WoL in 1588 register which is enabled > + * by default > + */ > + ret = phy_modify_mmd(phydev, MDIO_MMD_PCS, > + AT803X_PHY_MMD3_WOL_CTRL, > + AT803X_WOL_EN, 0); > + if (ret) > + return ret; > + Maybe it comes later in the patch series, but i would actually add a at8031_probe() which calls the common at803x_probe() and then does this WoL stuff. I don't see any reason to have just one probe, with if (phydev->drv->phy_id == ATH8031_PHY_ID) { in it. Andrew