On 30/11/2023 09:06, Krzysztof Kozlowski wrote:
On 29/11/2023 15:35, Konrad Dybcio wrote:
On 29.11.2023 15:05, Krzysztof Kozlowski wrote:
The TX Soundwire controller should take clock from TX macro codec, not
VA macro codec clock, otherwise the clock stays disabled. This looks
like a copy-paste issue, because the SC8280xp code uses here correctly
clock from TX macro. The VA macro clock is already consumed by TX macro
codec, thus it won't be disabled by this change.
Fixes: 61b006389bb7 ("arm64: dts: qcom: sm8550: add Soundwire controllers")
Reported-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
---
Interestingly, downstream 8550 has
qcom,use-clk-id = <VA_CORE_CLK>;
which doesn't seem to be used in techpack
In which node? I see it in the va-macro node, not the tx-macro.
Same I only see this in the va_macro.
Neil
Best regards,
Krzysztof
