On Wed, Nov 29, 2023 at 03:12:18AM +0100, Christian Marangi wrote: > diff --git a/drivers/net/phy/qcom/Makefile b/drivers/net/phy/qcom/Makefile > index 6a68da8aaa7b..43e4d14df8ea 100644 > --- a/drivers/net/phy/qcom/Makefile > +++ b/drivers/net/phy/qcom/Makefile > @@ -1,2 +1,3 @@ > # SPDX-License-Identifier: GPL-2.0 > -obj-$(CONFIG_AT803X_PHY) += at803x.o > +obj-$(CONFIG_AT803X_PHY) += at803x.o common.o > +obj-$(CONFIG_QCA83XX_PHY) += qca83xx.o common.o These PHY drivers can be built as modules. You will end up with several modules - at803x.ko, qca83xx.ko and common.ko. You don't mark any functions in common.c as exported, no module license, no author, no description. common.ko is way too generic a name as well. Please think about this more and test building these drivers as a module. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
