On 11/27/2023 5:37 PM, Simon Horman wrote:
On Wed, Nov 15, 2023 at 11:25:08AM +0800, Luo Jie wrote:
For the platform ipq5332, the related GCC clocks need to be enabled
to make the GPIO reset of the MDIO slave devices taking effect.
Signed-off-by: Luo Jie <quic_luoj@xxxxxxxxxxx>
---
drivers/net/mdio/mdio-ipq4019.c | 67 +++++++++++++++++++++++++++++----
1 file changed, 60 insertions(+), 7 deletions(-)
diff --git a/drivers/net/mdio/mdio-ipq4019.c b/drivers/net/mdio/mdio-ipq4019.c
index 9d444f5f7efb..a77982a1a1e1 100644
--- a/drivers/net/mdio/mdio-ipq4019.c
+++ b/drivers/net/mdio/mdio-ipq4019.c
...
+const char *const mdio_clk_name[] = {
+ "gcc_mdio_ahb_clk",
+ "gcc_uniphy0_ahb_clk",
+ "gcc_uniphy0_sys_clk",
+ "gcc_uniphy1_ahb_clk",
+ "gcc_uniphy1_sys_clk"
};
Hi Luo Jie,
A minor nit from my side: It appears that mdio_clk_name is only
used in this file. If so it should be declared as static.
...
Hi Simon,
The mdio_clk_name is only used in this file, will update to use
static, thanks.
