hi Krzysztof, Sure . Will take care of dtbs_check warnings in the next patch . Thanks Suraj On 11/24/2023 1:48 PM, Krzysztof Kozlowski wrote: > On 23/11/2023 12:38, Suraj Jaiswal wrote: >> Add binding doc for fault IRQ. The fault IRQ will be >> trigger for ECC,DPP,FSM error. >> >> Signed-off-by: Suraj Jaiswal <quic_jsuraj@xxxxxxxxxxx> >> --- >> Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 7 +++++-- >> 1 file changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml >> index 7bdb412a0185..e013cb51fb07 100644 >> --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml >> +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml >> @@ -37,12 +37,14 @@ properties: >> items: >> - description: Combined signal for various interrupt events >> - description: The interrupt that occurs when Rx exits the LPI state >> + - description: The interrupt that occurs when HW fault occurs > > Adding required items is breaking the ABI and introducing new dtbs_check > warnings. I don't see rationale for this in the commit msg. > > I don't see any fixes for the warnings, either. I am quite picky on this > part, so to avoid wasting my time - are you 100% sure you do not > introduce any new warning? > > Best regards, > Krzysztof >