On 24/11/2023 07:17, Mao Jinlong wrote:
> Fix all warnings in Qualcomm boards coming from Coresight bindings.
One logical thing, one patch. That applies not only to Linux kernel, but
to all software projects.
>
> Signed-off-by: Mao Jinlong <quic_jinlmao@xxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/msm8996.dtsi | 26 ----------------------
> arch/arm64/boot/dts/qcom/msm8998.dtsi | 32 +++++++++++++++++----------
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 5 +----
> arch/arm64/boot/dts/qcom/sm8150.dtsi | 5 +----
> arch/arm64/boot/dts/qcom/sm8250.dtsi | 24 ++++----------------
> 5 files changed, 26 insertions(+), 66 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index 6ba9da9e6a8b..e42c22b26adc 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -2637,24 +2637,6 @@ funnel1_out: endpoint {
> };
> };
>
> - funnel@3023000 {
> - compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
> - reg = <0x3023000 0x1000>;
> -
> - clocks = <&rpmcc RPM_QDSS_CLK>, <&rpmcc RPM_QDSS_A_CLK>;
> - clock-names = "apb_pclk", "atclk";
> -
> -
> - out-ports {
> - port {
> - funnel2_out: endpoint {
> - remote-endpoint =
> - <&merge_funnel_in2>;
> - };
> - };
> - };
> - };
Why do you remove nodes? How is this anyhow related to commit msg?
Nothing here is explained.
> -
> funnel@3025000 {
> compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
> reg = <0x3025000 0x1000>;
> @@ -2681,14 +2663,6 @@ merge_funnel_in1: endpoint {
> <&funnel1_out>;
> };
> };
> -
> - port@2 {
> - reg = <2>;
> - merge_funnel_in2: endpoint {
> - remote-endpoint =
> - <&funnel2_out>;
> - };
Why?
> - };
> };
>
> out-ports {
> diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
> index b485bf925ce6..ebc5ba1b369e 100644
> --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
> @@ -2031,9 +2031,11 @@ etm5: etm@7c40000 {
>
> cpu = <&CPU4>;
>
> - port {
> - etm4_out: endpoint {
> - remote-endpoint = <&apss_funnel_in4>;
> + out-ports {
> + port {
So you want to say out-ports is missing? Commit msg is really not
explaining anything.
> + etm4_out: endpoint {
> + remote-endpoint = <&apss_funnel_in4>;
> + };
> };
Best regards,
Krzysztof
