On Thu, Nov 23, 2023 at 05:08:15PM +0530, Suraj Jaiswal wrote: > Add IRQ support to listen HW fault like ECC,DPP,FSM > fault and print the fault information in the kernel > log. > > Signed-off-by: Suraj Jaiswal <quic_jsuraj@xxxxxxxxxxx> ... > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > index 1ffde555da47..bae1704d5f4b 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > @@ -690,9 +690,25 @@ devm_stmmac_probe_config_dt(struct platform_device *pdev, u8 *mac) > #endif /* CONFIG_OF */ > EXPORT_SYMBOL_GPL(devm_stmmac_probe_config_dt); > > +int stmmac_get_fault_intr_config(struct platform_device *pdev, struct stmmac_resources *res) Hi Suraj, stmmac_get_fault_intr_config() appears to only be used in this function. If so it should be static. Also, please consider limiting Networking code to 80 columns wide. static int stmmac_get_fault_intr_config(struct platform_device *pdev, struct stmmac_resources *res) ... -- pw-bot: changes-requested
