On 20/11/2023 20:26, Andy Shevchenko wrote:
> The group is not used anywhere, remove it. And if needed, it should be
> struct pingroup anyway.
>
> While at it, replace kernel.h with what exactly being used.
Missing Reported-by and Closes by for LKP... Unless you discovered it
without its report?
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
>
> _Seems_ like this (I only read the code), hence rft.
>
> drivers/pinctrl/qcom/pinctrl-lpass-lpi.h | 6 +----
> .../pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c | 16 -------------
> .../pinctrl/qcom/pinctrl-sc8280xp-lpass-lpi.c | 20 ----------------
> .../pinctrl/qcom/pinctrl-sm6115-lpass-lpi.c | 20 ----------------
> .../pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c | 15 ------------
> .../pinctrl/qcom/pinctrl-sm8350-lpass-lpi.c | 16 -------------
> .../pinctrl/qcom/pinctrl-sm8450-lpass-lpi.c | 24 -------------------
Missing sm8550.
> 7 files changed, 1 insertion(+), 116 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.h b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.h
> index 206b2c0ca828..a9b2f65c1ebe 100644
> --- a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.h
> +++ b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.h
> @@ -6,8 +6,8 @@
> #ifndef __PINCTRL_LPASS_LPI_H__
> #define __PINCTRL_LPASS_LPI_H__
>
> +#include <linux/array_size.h>
> #include <linux/bits.h>
> -#include <linux/kernel.h>
>
> #include "../core.h"
>
> @@ -45,11 +45,8 @@ struct pinctrl_pin_desc;
>
> #define LPI_PINGROUP(id, soff, f1, f2, f3, f4) \
> { \
> - .group.name = "gpio" #id, \
> - .group.pins = gpio##id##_pins, \
Aren't these used by core pinctrl code?
Best regards,
Krzysztof
