> + for (ret = 0; ret < ETH_LDO_RDY_CNT; ret++) {
> + if (priv->eth_ldo_rdy[ret]) {
> + val = readl(priv->eth_ldo_rdy[ret]);
> + val |= BIT(0);
> + writel(val, priv->eth_ldo_rdy[ret]);
> + fsleep(IPQ_PHY_SET_DELAY_US);
> + }
Please add a new variable, rather than use ret this way.
> + for (ret = 0; ret < ETH_LDO_RDY_CNT; ret++) {
> + res = platform_get_resource(pdev, IORESOURCE_MEM, ret + 1);
> + if (res)
> + priv->eth_ldo_rdy[ret] = devm_ioremap(&pdev->dev,
same here.
Andrew
---
pw-bot: cr
