On 10/11/2023 03:06, Hui Liu via B4 Relay wrote: > From: Hui Liu <quic_huliu@xxxxxxxxxxx> > > Add definition for three LEDs to make sure they can > be enabled base on QCOM LPG LED driver. > > Signed-off-by: Hui Liu <quic_huliu@xxxxxxxxxxx> > --- > Changes in v2: > - Rephrased commit text and updated the nodes to board file. > - Link to v1: https://lore.kernel.org/r/20231108-qcom_leds-v1-1-c3e1c8572cb0@xxxxxxxxxxx > --- > arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > index 2ff549f4dc7a..228e2aaeb861 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > @@ -7,6 +7,7 @@ > > #include <dt-bindings/iio/qcom,spmi-adc7-pmk8350.h> > #include <dt-bindings/input/linux-event-codes.h> > +#include <dt-bindings/leds/common.h> > #include "sc7280.dtsi" > #include "pm7325.dtsi" > #include "pm8350c.dtsi" > @@ -365,6 +366,30 @@ vreg_bob: bob { > }; > }; > > +&pm8350c_pwm { > + status = "okay"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + led@1 { > + reg = <1>; > + color = <LED_COLOR_ID_RED>; > + label = "red"; Drop labels. You already have color, so you miss function. Best regards, Krzysztof
