Re: [PATCH] ARM: dts: qcom: Add LPG LED device description

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 11/8/2023 2:59 PM, Dmitry Baryshkov wrote:
On Wed, 8 Nov 2023 at 08:05, Hui Liu via B4 Relay
<devnull+quic_huliu.quicinc.com@xxxxxxxxxx> wrote:

From: Hui Liu <quic_huliu@xxxxxxxxxxx>

Add LPG LED device description.

No. You are not adding "LPG LED device description". You are adding
definition for three LEDs.
OK, I will update the commit in next patch.



Signed-off-by: Hui Liu <quic_huliu@xxxxxxxxxxx>
---
  arch/arm64/boot/dts/qcom/pm8350c.dtsi | 22 ++++++++++++++++++++++
  1 file changed, 22 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/pm8350c.dtsi b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
index f28e71487d5c..11b9f384d99c 100644
--- a/arch/arm64/boot/dts/qcom/pm8350c.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
@@ -4,6 +4,7 @@
   */

  #include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/leds/common.h>
  #include <dt-bindings/spmi/spmi.h>

  &spmi_bus {
@@ -34,6 +35,27 @@ pm8350c_pwm: pwm {
                         compatible = "qcom,pm8350c-pwm";
                         #pwm-cells = <2>;
                         status = "disabled";
+
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+
+                       led@1 {
+                               reg = <1>;
+                               color = <LED_COLOR_ID_RED>;
+                               label = "red";
+                       };
+
+                       led@2 {
+                               reg = <2>;
+                               color = <LED_COLOR_ID_GREEN>;
+                               label = "green";
+                       };
+
+                       led@3 {
+                               reg = <3>;
+                               color = <LED_COLOR_ID_BLUE>;
+                               label = "blue";

... and these particular LEDs are board-specific. Please fill them in
the board file instead.

Sure, I will add these node in board file.

+                       };
                 };
         };
  };

---
base-commit: b9604be241587fb29c0f40450e53d0a37dc611b5
change-id: 20231108-qcom_leds-c3b0b7029008

Best regards,
--
Hui Liu <quic_huliu@xxxxxxxxxxx>








[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux