Re: [PATCH] dma: fix returnvar.cocci warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Nov 8, 2015 at 9:45 AM, Julia Lawall <julia.lawall@xxxxxxx> wrote:
>  Remove unneeded variable used to store return value.
>
> Generated by: scripts/coccinelle/misc/returnvar.cocci
>
> CC: Sinan Kaya <okaya@xxxxxxxxxxxxxx>
> Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>

Who is the author?
I suppose Fengguang is the reporter, right?

> ---
>
>  hidma_ll.c |    6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> --- a/drivers/dma/qcom/hidma_ll.c
> +++ b/drivers/dma/qcom/hidma_ll.c
> @@ -567,14 +567,13 @@ int hidma_ll_resume(struct hidma_lldev *
>
>  static int hidma_ll_hw_start(struct hidma_lldev *lldev)
>  {
> -       int rc = 0;
>         unsigned long irqflags;
>
>         spin_lock_irqsave(&lldev->lock, irqflags);
>         writel(lldev->tre_write_offset, lldev->trca + TRCA_DOORBELL_OFFSET);
>         spin_unlock_irqrestore(&lldev->lock, irqflags);
>
> -       return rc;
> +       return 0;
>  }
>
>  bool hidma_ll_isenabled(struct hidma_lldev *lldev)
> @@ -600,7 +599,6 @@ bool hidma_ll_isenabled(struct hidma_lld
>  int hidma_ll_queue_request(struct hidma_lldev *lldev, u32 tre_ch)
>  {
>         struct hidma_tre *tre;
> -       int rc = 0;
>         unsigned long flags;
>
>         tre = &lldev->trepool[tre_ch];
> @@ -618,7 +616,7 @@ int hidma_ll_queue_request(struct hidma_
>         lldev->tre_write_offset = (lldev->tre_write_offset + TRE_SIZE)
>                                 % lldev->tre_ring_size;
>         spin_unlock_irqrestore(&lldev->lock, flags);
> -       return rc;
> +       return 0;
>  }
>
>  int hidma_ll_start(struct hidma_lldev *lldev)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux