On Sun, Nov 05, 2023 at 10:11:42AM -0500, Tyler Stachecki wrote: > On Sun, Nov 05, 2023 at 10:05:10AM -0500, Tyler J. Stachecki wrote: > > Add support for the Sierra Wireless EM9291 modem. > > Empirically, it seems to use the same configuration as > > EM9191. > > > > $ lspci -vv > > 03:00.0 Unassigned class [ff00]: Qualcomm Device 0308 > > Subsystem: Device 18d7:0301 > > > > > > Hi Mani, > > I just want to highlight "empirically" here. I do not have > access to the IP which confirms proper MHI configuration > here. Given that, not sure it is appropriate for submission > to the kernel. > > However, without these changes, AT is not exposed and QMI > submissions time out -- so better than nothing...? > Yes, and that's how some other modem support is added as well. So it is totally fine. Thanks for the patch! - Mani > Regards, > Tyler > -- மணிவண்ணன் சதாசிவம்