Doug Anderson писал(а) 31.10.2023 02:55: > Hi, > > On Mon, Oct 30, 2023 at 2:47 PM Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote: >> >> On 27.10.2023 16:42, Nikita Travkin wrote: >> > pm6150 has a read-only RTC that can be used to keep the time with some >> > extra userspace tools. Enable it. >> > >> > Signed-off-by: Nikita Travkin <nikita@xxxxxxx> >> > --- >> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> >> >> kinda unsure why it'd ever be disabled >> >> Konrad > > FWIW we don't use the PMIC RTC in Chrome boards. I can't quite > remember why, but I _think_ that the power lines aren't hooked up to > the PMIC to keep power on for the board's lowest power states. > Instead we use the RTC that's on the EC (Embedded Controller). > When it was submitted, I suggested to keep it disabled by default because of the firmware mess qcom has - the rtc is set to read-only and if one enables it on cros without allow-set-time; and validating that qtiseclib doesn't block it too, it would likely cause issues by taking devices back to 1970s :D Nikita > -Doug
