Re: [PATCH 1/2] arm64: dts: qcom: sdm845-oneplus: enable flash LED

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Caleb Connolly <caleb.connolly@xxxxxxxxxx>
Subject: Re: [PATCH 1/2] arm64: dts: qcom: sdm845-oneplus: enable flash LED
From: Pavel Machek <pavel@xxxxxx>
Date: Sat, 28 Oct 2023 12:39:27 +0200
Cc: Andy Gross <agross@xxxxxxxxxx>, Bjorn Andersson <andersson@xxxxxxxxxx>, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>, Rob Herring <robh+dt@xxxxxxxxxx>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>, Conor Dooley <conor+dt@xxxxxxxxxx>, linux-arm-msm@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, ~postmarketos/upstreaming@xxxxxxxxxxx, phone-devel@xxxxxxxxxxxxxxx
In-reply-to: <20231001-b4-sdm845-flash-dts-v1-1-275a3abb0b10@linaro.org>
References: <20231001-b4-sdm845-flash-dts-v1-0-275a3abb0b10@linaro.org> <20231001-b4-sdm845-flash-dts-v1-1-275a3abb0b10@linaro.org>

Hi!

> +	led-1 {
> +		function = LED_FUNCTION_FLASH;
> +		color = <LED_COLOR_ID_YELLOW>;

That's warm white, not yellow. We should likely create a define for
that.

BR,
								Pavel
--

References:
- [PATCH 0/2] dts: qcom: enable flash LED on OnePlus 6 and PocoPhone F1
  - From: Caleb Connolly
- [PATCH 1/2] arm64: dts: qcom: sdm845-oneplus: enable flash LED
  - From: Caleb Connolly

Prev by Date: Re: [PATCH v2 1/4] dt-bindings: mfd: qcom,tcsr: Add compatible for sm8250/sm8350
Next by Date: Re: [PATCH 0/2] arm64: dts: qcom: longcheer l8910 and l9100: Enable RGB LED
Previous by thread: Re: [PATCH 1/2] arm64: dts: qcom: sdm845-oneplus: enable flash LED
Next by thread: [PATCH 2/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable flash led
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [Linux for Sparc] [IETF Annouce] [Security] [Bugtraq] [Linux MIPS] [ECOS] [Asterisk Internet PBX] [Linux API]

Powered by Linux