On 26/10/2023 15:24, Stefan Hansson wrote: > According to the dts from the kernel source code released by Samsung, > matissewifi and matisselte only have minor differences in hardware, so > use a shared dtsi to reduce duplicated code. Additionally, this should > make adding support for matisse3g easier should someone want to do that > at a later point. > > As such, add a common device tree for all matisse devices by Samsung > based on the matissewifi dts. Support for matisselte will be introduced > in a later patch in this series and will use the common dtsi as well. > > Signed-off-by: Stefan Hansson <newbyte@xxxxxxxxxxxxxxxx> > --- > .../qcom-apq8026-samsung-matisse-wifi.dts | 595 +++--------------- > ... qcom-msm8226-samsung-matisse-common.dtsi} | 66 -- > 2 files changed, 76 insertions(+), 585 deletions(-) > rewrite arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts (85%) > copy arch/arm/boot/dts/qcom/{qcom-apq8026-samsung-matisse-wifi.dts => qcom-msm8226-samsung-matisse-common.dtsi} (86%) Thanks. For me this diff is much more readable - I clearly see what was removed from final DTSI file thus what I should expect in DTS file. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof