On Thu, 26 Oct 2023 at 23:49, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote: > > > > On 10/26/23 22:47, Dmitry Baryshkov wrote: > > On Thu, 26 Oct 2023 at 21:57, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote: > >> > >> > >> > >> On 10/7/23 01:43, Konrad Dybcio wrote: > >>> On 4.10.2023 02:31, Dmitry Baryshkov wrote: > >>>> clk_rcg2_shared_ops implements support for the case of the RCG which > >>>> must not be completely turned off. However its design has one major > >>>> drawback: it doesn't allow us to properly implement the is_enabled > >>>> callback, which causes different kinds of misbehaviour from the CCF. > >>>> > >>>> Follow the idea behind clk_regmap_phy_mux_ops and implement the new > >>>> clk_rcg2_parked_ops. It also targets the clocks which must not be fully > >>>> switched off (and shared most of the implementation with > >>>> clk_rcg2_shared_ops). The major difference is that it requires that the > >>>> parent map doesn't conain the safe (parked) clock source. Instead if the > >>>> CFG_REG register points to the safe source, the clock is considered to > >>>> be disabled. > >>>> > >>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > >>>> --- > >>> Would the intention here be to replace all usages of _shared_? > > > > Yes > Then I suppose an immediate followup question would be: "why > introduce new ops instead of replacing the existing ones in the > patchset?". Because using this ops requires doing more than just replacing the name. it also requires dropping the XO source from the parent maps. So I'd prefer to perform this migration on a driver-by-driver basis. Otherwise it might be very easy to introduce a mistake somewhere. -- With best wishes Dmitry
