On 10/26/23 13:34, Bryan O'Donoghue wrote:
On 26/10/2023 12:21, Konrad Dybcio wrote:
+ .flags = HW_CTRL | RETAIN_FF_ENABLE,
This should really be HW_CTRL_TRIGGER from [1]
and then downstream uses cam_bps_transfer_gdsc_control and
cam_bps_get_gdsc_control to control hw (fast) or sw (normal) mode
similarly in drivers/cam_icp/icp_hw/ipe_hw/ipe_soc.c for IPE
I'm happy to do such a conversion if said patch hits -next, qcom-next or clk-next before this patch, otherwise I'd rather not gate this driver on stuff that's not queued anywhere.
There's alot of CAMSS stuff driver/compat/dtsi that is gated on having the CAMCC upstream, effectively all of the CAMSS stuff for sc8280xp.
Fair ?
Fair
Konrad
