These changes are needed to enable download mode on chipset like IPQ9574 and IPQ5332 SoCs or also will help enabling crash dump on multiple Qualcomm Soc with proper handling of download mode bits. First two changes(1/3-2/3) are SCM driver specific while 3/3 from pinctrl try to use the introduced API(1/3) via removing the existing logic. Changes from v7: https://lore.kernel.org/lkml/1696440338-12561-1-git-send-email-quic_mojha@xxxxxxxxxxx/ - Rebased it on next-20231025. - Added reviewed-by tag and take care of comment made about commit text should be in imperative mode. - Modified the name of the API to qcom_scm_io_rmw() as per suggestion made by [Dmitry] - Moved spinlock inside qcom_scm structure. - Corrected the patch order as per subsystem SCM first then pinctrl. Change from minidump-v5(13/17-15/17):https://lore.kernel.org/lkml/1694429639-21484-1-git-send-email-quic_mojha@xxxxxxxxxxx/ - Removed mistakenly added macros. https://lore.kernel.org/lkml/9da888dc-401a-4cbb-b616-b4654fa79e35@xxxxxxxxxxx/ - Added Acked-by tag from Linus.w to 2/3. Changes from dload series v6: https://lore.kernel.org/lkml/1680076012-10785-1-git-send-email-quic_mojha@xxxxxxxxxxx/ - Rebased it on latest tag available on linux-next - Added missed Poovendhan sign-off on 15/17 and tested-by tag from Kathiravan. Thanks to him for testing and reminding me of missing sign-off. - Addressed comments made on dload mode patch v6 version Changes in v6: - Applied suggested API change(at v4) by [dmitry.baryshkov] Changes in v5: https://lore.kernel.org/lkml/1680017869-22421-1-git-send-email-quic_mojha@xxxxxxxxxxx/ - Tried to fix the issue reported by kernel test robot https://lore.kernel.org/lkml/202303280535.acb66sQT-lkp@xxxxxxxxx/ - Applied some of the improvement suggested by [Bjorn.andersson] . Dropped 'both' instead support full,mini or mini,full for setting download mode to collect both minidump and full dump. . logging improvement. Changes in v4: https://lore.kernel.org/lkml/1679935281-18445-1-git-send-email-quic_mojha@xxxxxxxxxxx/ - val should be shifted within the function [srinivas.kandagatla] i.e new = (old & ~mask) | (val << ffs(mask) - 1); - Added Acked-by [linus.walleij] on pinctrl change. Changes in v3 : https://lore.kernel.org/lkml/1679070482-8391-1-git-send-email-quic_mojha@xxxxxxxxxxx/ - Removed [1] from the series and sent as a separate patch[2], although this series should be applied on top [2]. [1] https://lore.kernel.org/lkml/1677664555-30191-2-git-send-email-quic_mojha@xxxxxxxxxxx/ [2] https://lore.kernel.org/lkml/1678979666-551-1-git-send-email-quic_mojha@xxxxxxxxxxx/ - Introduce new exported symbol on suggestion from [srinivas.kandagatla] - Use the symbol from drivers/pinctrl/qcom/pinctrl-msm.c. - Addressed comment given by [dmitry.baryshkov] - Converted non-standard Originally-by to Signed-off-by. Changes in v2: https://lore.kernel.org/lkml/1677664555-30191-1-git-send-email-quic_mojha@xxxxxxxxxxx/ - Addressed comment made by [bjorn] - Added download mask. - Passed download mode as parameter - Accept human accepatable download mode string. - enable = !!dload_mode - Shifted module param callback to somewhere down in the file so that it no longer need to know the prototype of qcom_scm_set_download_mode() - updated commit text. Mukesh Ojha (3): firmware: qcom_scm: provide a read-modify-write function firmware: scm: Modify only the download bits in TCSR register pinctrl: qcom: Use qcom_scm_io_rmw() function drivers/firmware/qcom/qcom_scm.c | 38 ++++++++++++++++++++++++++++++++-- drivers/pinctrl/qcom/pinctrl-msm.c | 10 ++++----- include/linux/firmware/qcom/qcom_scm.h | 1 + 3 files changed, 41 insertions(+), 8 deletions(-) -- 2.7.4
