On Sun, 22 Oct 2023 at 13:51, Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> wrote: > > On Sat, 21 Oct 2023 at 13:20, Xilin Wu via B4 Relay > <devnull+wuxilin123.gmail.com@xxxxxxxxxx> wrote: > > > > From: Xilin Wu <wuxilin123@xxxxxxxxx> > > > > UCSI is supported on SM8350. Allow it to enable USB role switch and > > altmode notifications on SM8350. > > We have had troubles with UCSI on sm8350. I have a workaround for this > (and earlier) platforms. Once it is ready to be posted, I'll include > your patch in the series, if you don't mind. I ended up fixing the pmic_glink in a slightly different way, so I'll include a different patch in the posting. > > > > > Signed-off-by: Xilin Wu <wuxilin123@xxxxxxxxx> > > --- > > drivers/soc/qcom/pmic_glink.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/soc/qcom/pmic_glink.c b/drivers/soc/qcom/pmic_glink.c > > index 914057331afd..1196e79e6fb3 100644 > > --- a/drivers/soc/qcom/pmic_glink.c > > +++ b/drivers/soc/qcom/pmic_glink.c > > @@ -341,6 +341,7 @@ static const unsigned long pmic_glink_sm8450_client_mask = BIT(PMIC_GLINK_CLIENT > > BIT(PMIC_GLINK_CLIENT_UCSI); > > > > static const struct of_device_id pmic_glink_of_match[] = { > > + { .compatible = "qcom,sm8350-pmic-glink", .data = &pmic_glink_sm8450_client_mask }, > > { .compatible = "qcom,sm8450-pmic-glink", .data = &pmic_glink_sm8450_client_mask }, > > { .compatible = "qcom,sm8550-pmic-glink", .data = &pmic_glink_sm8450_client_mask }, > > { .compatible = "qcom,pmic-glink" }, > > > > -- > > 2.42.0 > > > > > -- > With best wishes > Dmitry -- With best wishes Dmitry