On 17/10/2023 12:18, Raymond Hackley wrote: > Input event code 139 stands for KEY_MENU, instead of KEY_OK as node name > key-ok inplies. Fix it with correct event code 0x160. > > Signed-off-by: Raymond Hackley <raymondhackley@xxxxxxxxxxxxxx> > --- > arch/arm/boot/dts/samsung/exynos4412-midas.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi b/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi > index 7daf25865551..3c1ae3c19828 100644 > --- a/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi > +++ b/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi > @@ -159,7 +159,7 @@ key-power { > > key-ok { > gpios = <&gpx0 1 GPIO_ACTIVE_LOW>; > - linux,code = <139>; > + linux,code = <0x160>; I applied this and was about to send in pull request, but it does not seem right, sorry. The button was always called "menu" button. Why changing it to OK? Just because of node name? The node name does not matter, this could be called "key-1" as well.. Best regards, Krzysztof