On 23/10/2023 11:20, Zhenhua Huang wrote: > Add bindings for the QCOM Memory Dump driver providing debug Bindings are for hardware, not driver. This suggests it is not suitable for bindings at all. > facilities. Firmware dumps system cache, internal memory, > peripheral registers to reserved DDR as per the table which > populated by the driver, after crash and warm reset. Again driver :/ > > Signed-off-by: Zhenhua Huang <quic_zhenhuah@xxxxxxxxxxx> > --- > .../bindings/soc/qcom/qcom,mem-dump.yaml | 42 +++++++++++++++++++++ > .../devicetree/bindings/sram/qcom,imem.yaml | 44 ++++++++++++++++++++++ > 2 files changed, 86 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,mem-dump.yaml > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,mem-dump.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,mem-dump.yaml > new file mode 100644 > index 0000000..87f8f51 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,mem-dump.yaml > @@ -0,0 +1,42 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/soc/qcom/qcom,mem-dump.yaml#"; > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"; Drop quotes. It does not look like you tested the bindings, at least after quick look. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint. > + > +title: Qualcomm memory dump Describe hardware, not driver. > + > +description: | > + Qualcomm memory dump driver dynamically reserves memory and provides hints(id and size) Again, driver, so not suitable for DTS and bindings. Best regards, Krzysztof
