On Mon, 23 Oct 2023 at 09:17, Jishnu Prakash <quic_jprakash@xxxxxxxxxxx> wrote: > > Hi Jonathan, > > On 7/8/2023 8:53 PM, Jonathan Cameron wrote: > > On Sat, 8 Jul 2023 12:58:33 +0530 > > Jishnu Prakash <quic_jprakash@xxxxxxxxxxx> wrote: > > > >> Update ADC dt-bindings file paths in QCOM ADC driver files to > >> match the dt-bindings change moving the files from 'iio' to > >> 'iio/adc' folder. > >> > >> Signed-off-by: Jishnu Prakash <quic_jprakash@xxxxxxxxxxx> > > Do the move in one go. > > > > Diff rename detection will make the resulting patch more trivial > > to look at than this multistep version. > > > > Jonathan > > > Hi Jonathan, > > Just to recap, in patches 8-11, the intention is to move the dt-binding > files used for QCOM ADCs from /dt-bindings/iio folder to the > /dt-bindings/iio/adc folder. > > I'm just confirming, can we move the files and update documentation, > bindings, driver and devicetree files all in one patch? Or you mean one > patch for documentation, bindings and driver files and one patch for > devicetree files (based on the comment from Krzysztof for the next patch > 10 in this series)? > > Based on this patch series: > https://lore.kernel.org/all/cover.1646388139.git.zong.li@xxxxxxxxxx/, > I'm wondering if I should add the files in the new location first, do > the file path updates and then completely remove the files in the old > path to avoid breaking the kernel.....or is it possible to get the > devicetree changes picked along with the binding changes, to avoid any > problems with bisectability? Perform git mv & fix all failing DT and drivers in a single commit. You might also update guarding defines, if you wish. Perform all other changes in a separate commit. This way git diff will actually tell what has happened, instead of us seeing a series of add files, perform changes, remove files. It is impossible to review your changes otherwise. > > > >> --- > >> drivers/iio/adc/qcom-spmi-adc5-gen3.c | 2 +- > >> drivers/iio/adc/qcom-spmi-adc5.c | 2 +- > >> drivers/iio/adc/qcom-spmi-vadc.c | 2 +- > >> 3 files changed, 3 insertions(+), 3 deletions(-) > >> > Thanks, > > Jishnu > -- With best wishes Dmitry
