Hi Krzysztof,
On 7/9/2023 11:08 PM, Krzysztof Kozlowski wrote:
On 08/07/2023 09:28, Jishnu Prakash wrote:
Now that usage of "ADC7" name has been replaced with usage of "ADC5
Gen2" name everywhere, remove the "qcom,spmi-adc7" compatible string.
Signed-off-by: Jishnu Prakash <quic_jprakash@xxxxxxxxxxx>
---
drivers/iio/adc/qcom-spmi-adc5.c | 4 ----
Your patchset is not bisectable. Neither this patch nor cover letter
marked this. This is not correct and will lead to broken kernels.
Even if not considering bisectability, this basically breaks the ABI
without any explanation and rationale.
Breaking ABI just because you want to rename something, is not the way
to go, so NAK. Sorry.
Best regards,
Krzysztof
I'll drop this patch and just mark the older name as deprecated. For
concerns on bisectability, I have asked some questions in my other
replies for this patch series, I'll structure my next patchsets
according to the replies I get.
Thanks,
Jishnu
