Hi Krzysztof,
On 7/9/2023 10:49 PM, Krzysztof Kozlowski wrote:
On 08/07/2023 09:28, Jishnu Prakash wrote:
Now that usage of "ADC7" name has been replaced with usage of "ADC5
Gen2" name everywhere, remove all support for "ADC7" name.
Why?
The idea is to replace usage of the name "ADC7" with "ADC5 Gen2"
everywhere possible, to match our internal convention and align better
with the "ADC5 Gen3" support I'm adding in this patch series - is it
better if I just update documentation and dtbindings directly in one
patch for ADC5 Gen2 and update devicetree in one patch after that for
the corresponding macro changes?
@@ -26,7 +26,6 @@ properties:
- qcom,spmi-vadc
- qcom,spmi-adc5
- qcom,spmi-adc-rev2
- - qcom,spmi-adc7
NAK. You did not explained why dropping existing compatible is correct,
expected and okay.
Also:
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.
Best regards,
Krzysztof
Yes, I'll avoid dropping the compatible, I'll just mark it deprecated as
Jonathan suggested, in a single bindings patch without having separate
patches for adding and removing support.
Will make sure to check subject prefixes too.
Thanks,
Jishnu
