On Thu, Oct 19, 2023 at 05:43:11PM +0300, Dmitry Baryshkov wrote:
> Since the commit 6812d1dfbca9 ("thermal/drivers/qcom/tsens-v0_1: Fix
> mdm9607 slope values") the default v0.1 implementation of tsens options
> is unused by the driver. Drop it now to stop compiler complaining about
> the unused static const. If the need for the default v0.1 ops struct
> arives, this commit can be easily reverted without further
> considerations.
>
> Fixes: 6812d1dfbca9 ("thermal/drivers/qcom/tsens-v0_1: Fix mdm9607 slope values")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
Seems like I remember correctly that there was a patch for this already
that wasn't picked up yet(?):
https://lore.kernel.org/linux-arm-msm/20230617113837.3224912-1-trix@xxxxxxxxxx/
It doesn't have the Fixes tag though. I think both patches are fine.
Thanks for fixing this. :-)
Stephan
> ---
> drivers/thermal/qcom/tsens-v0_1.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/thermal/qcom/tsens-v0_1.c b/drivers/thermal/qcom/tsens-v0_1.c
> index 87c09f62ee81..32d2d3e33287 100644
> --- a/drivers/thermal/qcom/tsens-v0_1.c
> +++ b/drivers/thermal/qcom/tsens-v0_1.c
> @@ -325,12 +325,6 @@ static const struct reg_field tsens_v0_1_regfields[MAX_REGFIELDS] = {
> [TRDY] = REG_FIELD(TM_TRDY_OFF, 0, 0),
> };
>
> -static const struct tsens_ops ops_v0_1 = {
> - .init = init_common,
> - .calibrate = tsens_calibrate_common,
> - .get_temp = get_temp_common,
> -};
> -
> static const struct tsens_ops ops_8226 = {
> .init = init_8226,
> .calibrate = tsens_calibrate_common,
> --
> 2.39.2
>
