Re: [PATCH V1 1/4] dt-bindings: ufs: qcom: Add qos property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 10/10/23 17:49, Maramaina Naresh wrote:
Add bindings for per-cpu QoS for QCOM UFS. This improves random io
performance by 20% for QCOM UFS.
The bindings addition improves performance? Cool :P

Please explain your changes and provide the "why".

[...]

@@ -318,5 +326,13 @@ examples:
                              <0 0>,
                              <0 0>;
              qcom,ice = <&ice>;
+            qos0 {
Looks like the indentation is off, also missing newline before subnodes.

+ cpumask = <0x0f>;This should be a CPU phandle array instead. Besides, can we not
determine this dynamically?

+                vote = <44>;
+            };
+            qos1 {
Missing newline between subnodes.

Konrad



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux