Hi, On Fri, Oct 6, 2023 at 10:43 AM Vijaya Krishna Nivarthi <quic_vnivarth@xxxxxxxxxxx> wrote: > > The code at unmap_if_dma label doesn't contain unmapping dma anymore but > has only fsm reset. > > Rename it to reset_if_dma accordingly. > > No functional change. > > Signed-off-by: Vijaya Krishna Nivarthi <quic_vnivarth@xxxxxxxxxxx> > --- > drivers/spi/spi-geni-qcom.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) I guess perhaps technically this could have: Fixes: 3a76c7ca9e77 ("spi: spi-geni-qcom: Do not do DMA map/unmap inside driver, use framework instead") ...since before that commit it _did_ do the unmap, right? ;-) In any case, this seems good to me: Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>