On 03/10/2023 16:29, Johan Hovold wrote: > The Qualcomm SPMI PMIC revid implementation is broken in multiple ways > that can lead to resource leaks and crashes. This series reworks the > implementation so that can be used safely. > > Included is also a rename of the SPMI device lookup helper which can > hopefully help prevent similar leaks from being reintroduced. > > Johan This is.. definitely a major improvement. Thanks for cleaning up my mess fwiw Acked-by: Caleb Connolly <caleb.connolly@xxxxxxxxxx> > > > Johan Hovold (5): > mfd: qcom-spmi-pmic: fix reference leaks in revid helper > mfd: qcom-spmi-pmic: fix revid implementation > mfd: qcom-spmi-pmic: switch to EXPORT_SYMBOL_GPL() > spmi: document spmi_device_from_of() refcounting > spmi: rename spmi device lookup helper > > drivers/mfd/qcom-spmi-pmic.c | 103 +++++++++++++++++++++++++---------- > drivers/spmi/spmi.c | 9 ++- > include/linux/spmi.h | 2 +- > 3 files changed, 80 insertions(+), 34 deletions(-) > -- // Caleb (they/them)
